feat: add component definition list endpoint #396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #396 +/- ##
========================================
- Coverage 0.70% 0.68% -0.03%
========================================
Files 8 8
Lines 2960 3081 +121
========================================
Hits 21 21
- Misses 2939 3060 +121
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
jvallesm
force-pushed
the
jvalles/ins-3680-create-component-list-endpoint
branch
5 times, most recently
from
da32097 to
75fc444
Compare
jvallesm
force-pushed
the
jvalles/ins-3680-create-component-list-endpoint
branch
3 times, most recently
from
0c704fa to
b0efb0f
Compare
jvallesm
force-pushed
the
jvalles/ins-3680-create-component-list-endpoint
branch
from
b0efb0f to
2163c27
Compare
jvallesm
requested review from
donch1989,
pinglin and
xiaofei-du
as code owners
heiruwu
pushed a commit
to instill-ai/api-gateway
that referenced
this pull request
Feb 29, 2024
Because - instill-ai/protobufs#277 modified the pagination in the component list endpoint - instill-ai/pipeline-backend#396 implements the change in the server This commit - Adapts the component list params to the new contract.
heiruwu
pushed a commit
to instill-ai/api-gateway
that referenced
this pull request
Feb 29, 2024
Because - instill-ai/protobufs#277 modified the pagination in the component list endpoint - instill-ai/pipeline-backend#396 implements the change in the server This commit - Adapts the component list params to the new contract.
donch1989
deleted the
jvalles/ins-3680-create-component-list-endpoint
branch
donch1989
pushed a commit
that referenced
this pull request
Feb 29, 2024
Because - Component page is going to be implemented in the website, requiring unified filtering and pagination. This commit - Implements the component list endpoint, which for now doesn't have filtering capabilities. - Moves the component, operator and connector list logic to the domain layer. - The number of params passed from the handler to the domain is reduced (>3 params starts to get cumbersome) by using the proto request / response params. We already use proto structs as domain types so it's pointless to create an almost identical type. - Integration tests are moved to `/pipeline` as there's a single API and keeping separated directories by entity will keep increasing the `make integration-test` command. - Leverages the connector and operator list code to build the component list. ## notes ⏭️ We'll insert and query the definitions into / from the database in order to have a more sensible pagination strategy and to unlock filtering.⚠️ Integration tests require instill-ai/api-gateway#139
donch1989
pushed a commit
that referenced
this pull request
Feb 29, 2024
🤖 I have created a release *beep* *boop* --- ## [0.23.0-beta](v0.22.0-beta...v0.23.0-beta) (2024-02-29) ### Features * add component definition list endpoint ([#396](#396)) ([b8728c1](b8728c1)) * rename blockchain connector type to application ([#397](#397)) ([80aa6a5](80aa6a5)) * support reference with `foo["bar"]` syntax ([#394](#394)) ([ed82215](ed82215)) * use `mgmtPB.Owner` to embed the owner information in response ([#392](#392)) ([d071461](d071461)) ### Miscellaneous Chores * release v0.23.0-beta ([4d5639b](4d5639b)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This was referenced Mar 1, 2024
donch1989
pushed a commit
that referenced
this pull request
Mar 1, 2024
🤖 I have created a release *beep* *boop* --- ## [0.23.0-beta](v0.22.0-beta...v0.23.0-beta) (2024-03-01) ### Features * add component definition list endpoint ([#396](#396)) ([b8728c1](b8728c1)) * rename blockchain connector type to application ([#397](#397)) ([80aa6a5](80aa6a5)) * support reference with `foo["bar"]` syntax ([#394](#394)) ([ed82215](ed82215)) * use `mgmtPB.Owner` to embed the owner information in response ([#392](#392)) ([d071461](d071461)) ### Bug Fixes * fix component ID with a hyphen cannot be referenced ([#401](#401)) ([1958168](1958168)) ### Miscellaneous Chores * release v0.23.0-beta ([e3ab340](e3ab340)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
This commit
/pipelineas there's a single API and keeping separated directories by entity will keep increasing themake integration-testcommand.notes
⏭️ We'll insert and query the definitions into / from the database in order to have a more sensible pagination strategy and to unlock filtering.
⚠️ Integration tests require instill-ai/api-gateway#139