feat: simplify openapi_specifications to data_specifications #411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #411 +/- ##
========================================
- Coverage 0.68% 0.67% -0.02%
========================================
Files 8 7 -1
Lines 3069 3120 +51
========================================
Hits 21 21
- Misses 3048 3099 +51
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
donch1989
pushed a commit
that referenced
this pull request
Mar 13, 2024
🤖 I have created a release *beep* *boop* --- ## [0.24.0-beta](v0.23.0-beta...v0.24.0-beta) (2024-03-13) ### Features * add migration script for new recipe format ([#415](#415)) ([af8a512](af8a512)) * Introduce component definition list filtering ([#410](#410)) ([08cf677](08cf677)) * revamp recipe format and implement iterator ([#405](#405)) ([1a676ff](1a676ff)) * simplify openapi_specifications to data_specifications ([#411](#411)) ([deaef9b](deaef9b)) * sort component list by score ([#412](#412)) ([2849555](2849555)) * support unimplemented release stages in component definitions ([#414](#414)) ([c235592](c235592)) ### Bug Fixes * allow incomplete configuration in includeIteratorComponentDetail(). ([#413](#413)) ([2999599](2999599)) * fix condition field bugs ([#417](#417)) ([ce720d5](ce720d5)) * fix missing error return in pipeline trigger ([a743ab1](a743ab1)) ### Miscellaneous Chores * release v0.24.0-beta ([e7373fd](e7373fd)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
donch1989
pushed a commit
that referenced
this pull request
Mar 13, 2024
🤖 I have created a release *beep* *boop* --- ## [0.24.0-beta](v0.23.0-beta...v0.24.0-beta) (2024-03-13) ### Features * add migration script for new recipe format ([#415](#415)) ([af8a512](af8a512)) * Introduce component definition list filtering ([#410](#410)) ([08cf677](08cf677)) * revamp recipe format and implement iterator ([#405](#405)) ([1a676ff](1a676ff)) * simplify openapi_specifications to data_specifications ([#411](#411)) ([deaef9b](deaef9b)) * sort component list by score ([#412](#412)) ([2849555](2849555)) * support unimplemented release stages in component definitions ([#414](#414)) ([c235592](c235592)) ### Bug Fixes * allow incomplete configuration in includeIteratorComponentDetail(). ([#413](#413)) ([2999599](2999599)) * fix condition field bugs ([#417](#417)) ([ce720d5](ce720d5)) * fix missing error return in pipeline trigger ([a743ab1](a743ab1)) ### Miscellaneous Chores * release v0.24.0-beta ([184f64e](184f64e)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
donch1989
pushed a commit
that referenced
this pull request
Mar 13, 2024
🤖 I have created a release *beep* *boop* --- ## [0.24.0-beta](v0.23.0-beta...v0.24.0-beta) (2024-03-13) ### Features * add migration script for new recipe format ([#415](#415)) ([af8a512](af8a512)) * Introduce component definition list filtering ([#410](#410)) ([08cf677](08cf677)) * revamp recipe format and implement iterator ([#405](#405)) ([1a676ff](1a676ff)) * simplify openapi_specifications to data_specifications ([#411](#411)) ([deaef9b](deaef9b)) * sort component list by score ([#412](#412)) ([2849555](2849555)) * support unimplemented release stages in component definitions ([#414](#414)) ([c235592](c235592)) ### Bug Fixes * allow incomplete configuration in includeIteratorComponentDetail(). ([#413](#413)) ([2999599](2999599)) * fix condition field bugs ([#417](#417)) ([ce720d5](ce720d5)) * fix missing error return in pipeline trigger ([a743ab1](a743ab1)) * fix missing param for Instill Model connector ([6d372bb](6d372bb)) ### Miscellaneous Chores * release v0.24.0-beta ([2cddefb](2cddefb)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
donch1989
pushed a commit
that referenced
this pull request
Mar 13, 2024
🤖 I have created a release *beep* *boop* --- ## [0.24.0-beta](v0.23.0-beta...v0.24.0-beta) (2024-03-13) ### Features * add migration script for new recipe format ([#415](#415)) ([af8a512](af8a512)) * Introduce component definition list filtering ([#410](#410)) ([08cf677](08cf677)) * revamp recipe format and implement iterator ([#405](#405)) ([1a676ff](1a676ff)) * simplify openapi_specifications to data_specifications ([#411](#411)) ([deaef9b](deaef9b)) * sort component list by score ([#412](#412)) ([2849555](2849555)) * support unimplemented release stages in component definitions ([#414](#414)) ([c235592](c235592)) ### Bug Fixes * allow incomplete configuration in includeIteratorComponentDetail(). ([#413](#413)) ([2999599](2999599)) * fix condition field bugs ([#417](#417)) ([ce720d5](ce720d5)) * fix missing error return in pipeline trigger ([a743ab1](a743ab1)) * fix missing param for Instill Model connector ([6d372bb](6d372bb)) ### Miscellaneous Chores * release v0.24.0-beta ([d4e3f2b](d4e3f2b)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
openapi_specificationfield in the pipeline. However, we don't really need that OpenAPI schema, and it makes our response very large and hard to read.data_specificationsfor iterator component as well.This commit
openapi_specificationintodata_specificationby preserving only the input and output JSON schema and removing the nested structure of the OpenAPI spec.data_specificationsgeneration in iterator component.