Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: revamp recipe format and implement iterator #405

Merged
merged 2 commits into from
Mar 5, 2024
Merged

Conversation

donch1989
Copy link
Member

Because:

  • The original recipe message utilized structpb to encapsulate every configuration, creating an implicit structure that posed a challenge for users or developers to comprehend the data structure. Given the distinct structures associated with various components, it is essential to explicitly expose them to the user.
  • A special iterator component for array data iteration is desired.

This commit:

  • Revamped the recipe with new Protobuf messages: StartComponent, EndComponent, OperatorComponent, ConnectorComponent, and IteratorComponent.
  • Implements iterator.

Note:

  • This is a breaking change in the interface, requiring an update to the implementation on the client-side.

Copy link

linear bot commented Mar 5, 2024

Copy link

codecov bot commented Mar 5, 2024

Codecov Report

Attention: Patch coverage is 0% with 266 lines in your changes are missing coverage. Please review.

Project coverage is 0.69%. Comparing base (729e8a4) to head (a3b9c5d).

Files Patch % Lines
pkg/service/convert.go 0.00% 139 Missing ⚠️
pkg/service/openapi.go 0.00% 116 Missing ⚠️
pkg/service/service.go 0.00% 11 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main    #405   +/-   ##
=====================================
  Coverage   0.68%   0.69%           
=====================================
  Files          8       8           
  Lines       3081    3037   -44     
=====================================
  Hits          21      21           
+ Misses      3060    3016   -44     
Flag Coverage Δ
unittests 0.69% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@donch1989 donch1989 merged commit 1a676ff into main Mar 5, 2024
13 checks passed
@donch1989 donch1989 deleted the huitang/ins-3341 branch March 5, 2024 08:48
donch1989 pushed a commit that referenced this pull request Mar 13, 2024
🤖 I have created a release *beep* *boop*
---


##
[0.24.0-beta](v0.23.0-beta...v0.24.0-beta)
(2024-03-13)


### Features

* add migration script for new recipe format
([#415](#415))
([af8a512](af8a512))
* Introduce component definition list filtering
([#410](#410))
([08cf677](08cf677))
* revamp recipe format and implement iterator
([#405](#405))
([1a676ff](1a676ff))
* simplify openapi_specifications to data_specifications
([#411](#411))
([deaef9b](deaef9b))
* sort component list by score
([#412](#412))
([2849555](2849555))
* support unimplemented release stages in component definitions
([#414](#414))
([c235592](c235592))


### Bug Fixes

* allow incomplete configuration in includeIteratorComponentDetail().
([#413](#413))
([2999599](2999599))
* fix condition field bugs
([#417](#417))
([ce720d5](ce720d5))
* fix missing error return in pipeline trigger
([a743ab1](a743ab1))


### Miscellaneous Chores

* release v0.24.0-beta
([e7373fd](e7373fd))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
donch1989 pushed a commit that referenced this pull request Mar 13, 2024
🤖 I have created a release *beep* *boop*
---


##
[0.24.0-beta](v0.23.0-beta...v0.24.0-beta)
(2024-03-13)


### Features

* add migration script for new recipe format
([#415](#415))
([af8a512](af8a512))
* Introduce component definition list filtering
([#410](#410))
([08cf677](08cf677))
* revamp recipe format and implement iterator
([#405](#405))
([1a676ff](1a676ff))
* simplify openapi_specifications to data_specifications
([#411](#411))
([deaef9b](deaef9b))
* sort component list by score
([#412](#412))
([2849555](2849555))
* support unimplemented release stages in component definitions
([#414](#414))
([c235592](c235592))


### Bug Fixes

* allow incomplete configuration in includeIteratorComponentDetail().
([#413](#413))
([2999599](2999599))
* fix condition field bugs
([#417](#417))
([ce720d5](ce720d5))
* fix missing error return in pipeline trigger
([a743ab1](a743ab1))


### Miscellaneous Chores

* release v0.24.0-beta
([184f64e](184f64e))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
donch1989 pushed a commit that referenced this pull request Mar 13, 2024
🤖 I have created a release *beep* *boop*
---


##
[0.24.0-beta](v0.23.0-beta...v0.24.0-beta)
(2024-03-13)


### Features

* add migration script for new recipe format
([#415](#415))
([af8a512](af8a512))
* Introduce component definition list filtering
([#410](#410))
([08cf677](08cf677))
* revamp recipe format and implement iterator
([#405](#405))
([1a676ff](1a676ff))
* simplify openapi_specifications to data_specifications
([#411](#411))
([deaef9b](deaef9b))
* sort component list by score
([#412](#412))
([2849555](2849555))
* support unimplemented release stages in component definitions
([#414](#414))
([c235592](c235592))


### Bug Fixes

* allow incomplete configuration in includeIteratorComponentDetail().
([#413](#413))
([2999599](2999599))
* fix condition field bugs
([#417](#417))
([ce720d5](ce720d5))
* fix missing error return in pipeline trigger
([a743ab1](a743ab1))
* fix missing param for Instill Model connector
([6d372bb](6d372bb))


### Miscellaneous Chores

* release v0.24.0-beta
([2cddefb](2cddefb))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
donch1989 pushed a commit that referenced this pull request Mar 13, 2024
🤖 I have created a release *beep* *boop*
---


##
[0.24.0-beta](v0.23.0-beta...v0.24.0-beta)
(2024-03-13)


### Features

* add migration script for new recipe format
([#415](#415))
([af8a512](af8a512))
* Introduce component definition list filtering
([#410](#410))
([08cf677](08cf677))
* revamp recipe format and implement iterator
([#405](#405))
([1a676ff](1a676ff))
* simplify openapi_specifications to data_specifications
([#411](#411))
([deaef9b](deaef9b))
* sort component list by score
([#412](#412))
([2849555](2849555))
* support unimplemented release stages in component definitions
([#414](#414))
([c235592](c235592))


### Bug Fixes

* allow incomplete configuration in includeIteratorComponentDetail().
([#413](#413))
([2999599](2999599))
* fix condition field bugs
([#417](#417))
([ce720d5](ce720d5))
* fix missing error return in pipeline trigger
([a743ab1](a743ab1))
* fix missing param for Instill Model connector
([6d372bb](6d372bb))


### Miscellaneous Chores

* release v0.24.0-beta
([d4e3f2b](d4e3f2b))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants