-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(integration): add identity to OAuth connections #699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jvallesm
requested review from
donch1989,
pinglin and
xiaofei-du
as code owners
October 4, 2024 14:37
jvallesm
commented
Oct 4, 2024
@@ -1985,7 +1985,7 @@ func (s *service) ListComponentRuns(ctx context.Context, req *pipelinepb.ListCom | |||
|
|||
return &pipelinepb.ListComponentRunsResponse{ | |||
ComponentRuns: pbComponentRuns, | |||
TotalSize: totalCount, | |||
TotalSize: int32(totalCount), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@donch1989 I didn't overthink the changes in this commit, I just wanted to fix the build after the breaking changes in instill-ai/protobufs@e04c859 and instill-ai/protobufs@9f778f0.
jvallesm
force-pushed
the
jvalles/chore-add-identity-to-oauth-conn
branch
from
October 4, 2024 14:42
0137e98
to
9ef67d3
Compare
jvallesm
force-pushed
the
jvalles/chore-add-identity-to-oauth-conn
branch
from
October 4, 2024 15:11
7f7f862
to
43eeebb
Compare
jvallesm
added a commit
to instill-ai/instill-core
that referenced
this pull request
Oct 4, 2024
Because - instill-ai/pipeline-backend#699 introduces a new database version. This commit - Updates the database version.
jvallesm
pushed a commit
that referenced
this pull request
Oct 8, 2024
🤖 I have created a release *beep* *boop* --- ## [0.42.0-beta](v0.41.0-beta...v0.42.0-beta) (2024-10-08) ### Features * **document:** repair pdf with libreoffice ([#683](#683)) ([b6a738f](b6a738f)) * **integration:** add identity to OAuth connections ([#699](#699)) ([e2e9237](e2e9237)) * merge worker into main process and optimize graceful shutdown mechanism ([#713](#713)) ([69b64a0](69b64a0)) * **universalai:** add instill credit function for universal ai component ([#680](#680)) ([9ce10b5](9ce10b5)) * use explicit parameter for target namespace when cloning pipeline ([#711](#711)) ([ab2e3a6](ab2e3a6)) * **web:** fix bug and add mock users' behaviours by chromedp ([#701](#701)) ([ca312fe](ca312fe)) ### Bug Fixes * **component:** use kebab-case for icon name ([#703](#703)) ([cd587e2](cd587e2)) * **document:** catch the error if the bbox is out of boundary ([#718](#718)) ([4fe03e6](4fe03e6)) * fix the component render error was not being returned ([#707](#707)) ([931f067](931f067)) * fix the wrong target namespace when cloning pipeline ([#706](#706)) ([75a757b](75a757b)) * **integration:** update GitHub scopes to read/write repository issues ([#709](#709)) ([c1cf4ce](c1cf4ce)) * **text:** fix the bug about the list position ([#712](#712)) ([49aed28](49aed28)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
display the identity that they used.
This commit
supported.