fix: fix condition field not working when component name has -
#362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
donch1989
requested review from
pinglin,
xiaofei-du and
jvallesm
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #362 +/- ##
=====================================
Coverage 0.70% 0.70%
=====================================
Files 8 8
Lines 2971 2971
=====================================
Hits 21 21
Misses 2950 2950
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
jvallesm
pushed a commit
that referenced
this pull request
Jan 15, 2024
🤖 I have created a release *beep* *boop* --- ## [0.20.0-beta](v0.19.0-beta...v0.20.0-beta) (2024-01-15) ### Features * inject mgmt_backend address into connector configuration ([ca2586c](ca2586c)) * **recipe:** use `${}` as reference syntax ([#358](#358)) ([f86fae1](f86fae1)) * remove controller-vdp ([#354](#354)) ([afc3d21](afc3d21)) * support `q` filter for fuzzy search on `id` ([#360](#360)) ([ec3b439](ec3b439)) * support dynamic connector and operator definition ([#359](#359)) ([1485877](1485877)) * support filter pipelines with visibility ([#357](#357)) ([499b112](499b112)) ### Bug Fixes * fix condition field not working when component name has `-` ([#362](#362)) ([92682ce](92682ce)) * fix wrong global reference for Numbers connector ([#363](#363)) ([5c5eda8](5c5eda8)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
donch1989
pushed a commit
that referenced
this pull request
Jan 15, 2024
🤖 I have created a release *beep* *boop* --- ## [0.20.0-beta](v0.19.0-beta...v0.20.0-beta) (2024-01-15) ### Features * inject mgmt_backend address into connector configuration ([ca2586c](ca2586c)) * **recipe:** use `${}` as reference syntax ([#358](#358)) ([f86fae1](f86fae1)) * remove controller-vdp ([#354](#354)) ([afc3d21](afc3d21)) * support `q` filter for fuzzy search on `id` ([#360](#360)) ([ec3b439](ec3b439)) * support dynamic connector and operator definition ([#359](#359)) ([1485877](1485877)) * support filter pipelines with visibility ([#357](#357)) ([499b112](499b112)) ### Bug Fixes * fix condition field not working when component name has `-` ([#362](#362)) ([92682ce](92682ce)) * fix includeDetailInRecipe() ([7d7749b](7d7749b)) * fix wrong global reference for Numbers connector ([#363](#363)) ([5c5eda8](5c5eda8)) ### Miscellaneous Chores * release v0.20.0-beta ([f5393ac](f5393ac)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
donch1989
pushed a commit
that referenced
this pull request
Jan 15, 2024
🤖 I have created a release *beep* *boop* --- ## [0.20.0-beta](v0.19.0-beta...v0.20.0-beta) (2024-01-15) ### Features * inject mgmt_backend address into connector configuration ([ca2586c](ca2586c)) * **recipe:** use `${}` as reference syntax ([#358](#358)) ([f86fae1](f86fae1)) * remove controller-vdp ([#354](#354)) ([afc3d21](afc3d21)) * support `q` filter for fuzzy search on `id` ([#360](#360)) ([ec3b439](ec3b439)) * support dynamic connector and operator definition ([#359](#359)) ([1485877](1485877)) * support filter pipelines with visibility ([#357](#357)) ([499b112](499b112)) ### Bug Fixes * fix condition field not working when component name has `-` ([#362](#362)) ([92682ce](92682ce)) * fix includeDetailInRecipe() ([7d7749b](7d7749b)) * fix wrong global reference for Numbers connector ([#363](#363)) ([5c5eda8](5c5eda8)) ### Miscellaneous Chores * release v0.20.0-beta ([150c83b](150c83b)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
-character, but our condition field didn't work with this name.This commit
-.