Skip to content

Commit

Permalink
fix(run): add namespace id in response (#511)
Browse files Browse the repository at this point in the history
Because

- dashboard needs pipeline/model namespace id to redirect

This commit

- add namespace id in response

---------

Co-authored-by: droplet-bot <[email protected]>
  • Loading branch information
joremysh and droplet-bot authored Nov 5, 2024
1 parent 0bc2591 commit 0f9ef80
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 0 deletions.
2 changes: 2 additions & 0 deletions model/model/v1alpha/model.proto
Original file line number Diff line number Diff line change
Expand Up @@ -1773,6 +1773,8 @@ message ModelRun {
// Requester ID. This field might be empty if the model run belongs to a
// deleted namespace.
string requester_id = 16 [(google.api.field_behavior) = OUTPUT_ONLY];
// Namespace ID.
string namespace_id = 17 [(google.api.field_behavior) = OUTPUT_ONLY];
}

// ListModelRunsRequest represents a request to list of model runs.
Expand Down
8 changes: 8 additions & 0 deletions openapi/v2/service.swagger.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -8449,6 +8449,10 @@ definitions:
Requester ID. This field might be empty if the model run belongs to a
deleted namespace.
readOnly: true
namespaceId:
type: string
description: Namespace ID.
readOnly: true
description: ModelRun contains information about a run of models.
ModelTriggerChartRecord:
type: object
Expand Down Expand Up @@ -9120,6 +9124,10 @@ definitions:
Requester ID. This field might be empty if the pipeline run belongs to a
deleted namespace.
readOnly: true
namespaceId:
type: string
title: Namespace ID
readOnly: true
description: PipelineRun represents a single execution of a pipeline.
PipelineTriggerChartRecord:
type: object
Expand Down
3 changes: 3 additions & 0 deletions vdp/pipeline/v1beta/pipeline.proto
Original file line number Diff line number Diff line change
Expand Up @@ -2075,6 +2075,9 @@ message PipelineRun {
// Requester ID. This field might be empty if the pipeline run belongs to a
// deleted namespace.
string requester_id = 20 [(google.api.field_behavior) = OUTPUT_ONLY];

// Namespace ID
string namespace_id = 21 [(google.api.field_behavior) = OUTPUT_ONLY];
}

// ComponentRun represents the execution details of a single component within a pipeline run.
Expand Down

0 comments on commit 0f9ef80

Please sign in to comment.