Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(mgmt,billing): refactor mgmt message, endpoints and add billing service #130

Merged
merged 9 commits into from
Jan 23, 2023
Merged

fix(mgmt,billing): refactor mgmt message, endpoints and add billing service #130

merged 9 commits into from
Jan 23, 2023

Conversation

xiaofei-du
Copy link
Member

Because

  • list, create, update, delete and lookup user operations should be admin API that is not exposed to the public internet

This commit

  • add billing service so each user is assigned with a billing plan
  • redesign mgmt-backend endpoints into Admin and Public APIs
  • update the message user fields

@xiaofei-du xiaofei-du changed the title chore(mgmt,billing) refactor mgmt-backend endpoint and add billing service chore(mgmt,billing): refactor mgmt-backend endpoint and add billing service Jan 23, 2023
@xiaofei-du xiaofei-du changed the title chore(mgmt,billing): refactor mgmt-backend endpoint and add billing service fix(mgmt,billing): refactor mgmt-backend endpoint and add billing service Jan 23, 2023
@xiaofei-du xiaofei-du changed the title fix(mgmt,billing): refactor mgmt-backend endpoint and add billing service fix(mgmt,billing): refactor mgmt message, endpoints and add billing service Jan 23, 2023
@xiaofei-du xiaofei-du marked this pull request as ready for review January 23, 2023 00:22
pinglin
pinglin requested changes Jan 23, 2023
View reviewed changes
vdp/billing/v1alpha/plan.proto Outdated Show resolved Hide resolved
vdp/billing/v1alpha/plan.proto Outdated Show resolved Hide resolved
@xiaofei-du xiaofei-du requested a review from pinglin January 23, 2023 00:59
pinglin
pinglin requested changes Jan 23, 2023
View reviewed changes
Copy link
Member

@pinglin pinglin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update openapi.

@xiaofei-du xiaofei-du requested a review from pinglin January 23, 2023 01:09
@xiaofei-du
Copy link
Member Author

Please update openapi.

Please check the latest commit.

@pinglin pinglin force-pushed the refactor-mgmt-backend branch 9 times, most recently from f75e00e to c26afed Compare January 23, 2023 01:58
@pinglin pinglin force-pushed the refactor-mgmt-backend branch from c26afed to 0c8f5a5 Compare January 23, 2023 02:13
@pinglin pinglin force-pushed the refactor-mgmt-backend branch from 0c8f5a5 to 112387e Compare January 23, 2023 02:30
@pinglin pinglin merged commit 366c0f8 into main Jan 23, 2023
@pinglin pinglin deleted the refactor-mgmt-backend branch January 23, 2023 02:31
@droplet-bot droplet-bot mentioned this pull request Jan 23, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pinglin pinglin pinglin approved these changes

@Phelan164 Phelan164 Awaiting requested review from Phelan164

Assignees
No one assigned
Labels
None yet
Projects
No open projects
🔮 Instill Core
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xiaofei-du @pinglin