Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vdp): add release stage to component definitions #283

Conversation

jvallesm
Copy link
Collaborator

@jvallesm jvallesm commented Mar 8, 2024

Because

  • Component page and auto-generated docs require a release stage, and unimplemented stages (coming soon / open for contributions) shouldn't be extracted from the version field.
    • Reasons: they don't compare well (0.1.0-alpha < 0.1.0-alpha.coming-soon < 0.1.0-coming-soon), version isn't as good as an enum to filter out unimplemented versions (if in the future we use the component definition table for fetching the connectors / operators in the console).

This commit

  • Adds and documents a release_stage enum and field to component definitions.

⏩ Next steps

  • Introduce property in existing definitions.json fields
  • Read this property when building the component definitions index in SQL.
  • Remove unimplemented components from connector and operator lists. Right now we don't have any component in this stage but as soon as we have one they will be load in the inmem list of definitions and they will appear in the console when building pipelines.
  • Update compogen to read release stages from this field instead of from version

@jvallesm jvallesm self-assigned this Mar 8, 2024
Copy link

linear bot commented Mar 8, 2024

@jvallesm jvallesm marked this pull request as ready for review March 8, 2024 10:45
@jvallesm jvallesm force-pushed the jvalles/ins-3737-implement-coming-soon-open-for-contributions-in branch from 33ba89b to 84eac25 Compare March 8, 2024 14:58
Copy link
Member

@donch1989 donch1989 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sense. LGTM

@jvallesm jvallesm merged commit 8c20b4b into main Mar 8, 2024
@jvallesm jvallesm deleted the jvalles/ins-3737-implement-coming-soon-open-for-contributions-in branch March 8, 2024 15:14
jvallesm added a commit to instill-ai/pipeline-backend that referenced this pull request Mar 8, 2024
…414)

Because

- Component page showcases unimplemented components with the "Open for
contribution" and "Coming soon" tags.

This commit

- Uses the new `release_stage` property introduced in
instill-ai/protobufs#283
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: 👋 Done
Development

Successfully merging this pull request may close these issues.

3 participants