Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(app): add topk and catalog in conv message #480

Merged
merged 2 commits into from
Oct 2, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions app/app/v1alpha/conversation.proto
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,14 @@ message Conversation {
string app_id = 3 [(google.api.field_behavior) = REQUIRED];
// conversation id/name
string id = 4 [(google.api.field_behavior) = REQUIRED];
// last used catalog uid
optional string last_used_catalog_uid = 5 [(google.api.field_behavior) = OPTIONAL];
// last used top k
optional uint32 last_used_top_k = 6 [(google.api.field_behavior) = OPTIONAL];
// creation time of the conversation
google.protobuf.Timestamp create_time = 5 [(google.api.field_behavior) = OUTPUT_ONLY];
google.protobuf.Timestamp create_time = 7 [(google.api.field_behavior) = OUTPUT_ONLY];
// update time of the conversation
google.protobuf.Timestamp update_time = 6 [(google.api.field_behavior) = OUTPUT_ONLY];
google.protobuf.Timestamp update_time = 8 [(google.api.field_behavior) = OUTPUT_ONLY];
}

// Message represents a single message in a conversation
Expand Down Expand Up @@ -109,7 +113,11 @@ message UpdateConversationRequest {
// conversation id
string conversation_id = 3 [(google.api.field_behavior) = REQUIRED];
// new conversation id
string new_conversation_id = 4 [(google.api.field_behavior) = REQUIRED];
optional string new_conversation_id = 4 [(google.api.field_behavior) = OPTIONAL];
// last used catalog uid
optional string last_used_catalog_uid = 5 [(google.api.field_behavior) = OPTIONAL];
// last used top k
optional uint32 last_used_top_k = 6 [(google.api.field_behavior) = OPTIONAL];
}

// UpdateConversationResponse returns the updated conversation
Expand Down
16 changes: 14 additions & 2 deletions openapiv2/app/service.swagger.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -748,9 +748,14 @@ definitions:
newConversationId:
type: string
title: new conversation id
lastUsedCatalogUid:
type: string
title: last used catalog uid
lastUsedTopK:
type: integer
format: int64
title: last used top k
title: UpdateConversationRequest is used to update a conversation
required:
- newConversationId
AppPublicServiceUpdateMessageBody:
type: object
properties:
Expand Down Expand Up @@ -925,6 +930,13 @@ definitions:
id:
type: string
title: conversation id/name
lastUsedCatalogUid:
type: string
title: last used catalog uid
lastUsedTopK:
type: integer
format: int64
title: last used top k
createTime:
type: string
format: date-time
Expand Down