Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement initial CI integrations #7

Merged
merged 10 commits into from
Jun 4, 2024

Conversation

nathan-weinberg
Copy link
Member

@nathan-weinberg nathan-weinberg commented Jun 3, 2024

Resolves #4

This PR implements the following CI integrations:

  • Dependabot via a GitHub Action configuration
  • Markdown Linting implemented via Makefile as well as a Hardened GitHub Action
  • Spellchecking implemented via tox (with a Makefile entrypoint) as well as a Hardened GitHub Action
  • Action Linting implemented via Makefile as well as a Hardened GitHub Action
  • Python Linting and Formatting via tox using ruff and isort (with a Makefile entrypoint)

It also addresses Markdown and Python linting errors that are now being detected

Signed-off-by: Nathan Weinberg <[email protected]>
Signed-off-by: Nathan Weinberg <[email protected]>
Signed-off-by: Nathan Weinberg <[email protected]>
Signed-off-by: Nathan Weinberg <[email protected]>
@russellb russellb self-requested a review June 3, 2024 21:48
@russellb
Copy link
Member

russellb commented Jun 3, 2024

Let me know when this is ready for review.

@nathan-weinberg nathan-weinberg marked this pull request as ready for review June 4, 2024 01:40
Copy link
Contributor

@bjhargrave bjhargrave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM

@nathan-weinberg
Copy link
Member Author

Let me know when this is ready for review.

This should be good to go - can't test the actions themselves in this PR but everything other than Dependabot can be run locally

@nathan-weinberg
Copy link
Member Author

I can squash commits if desired, left them separated for easier reviewing since this is a fairly large PR

Signed-off-by: Nathan Weinberg <[email protected]>
@russellb russellb merged commit 7e452b7 into instructlab:main Jun 4, 2024
@nathan-weinberg nathan-weinberg deleted the initial-ci branch June 4, 2024 15:03
bbrowning pushed a commit that referenced this pull request Dec 10, 2024
fixing bugs in raft and sdg llm block
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Initialize base CI jobs
4 participants