[MBL-18120][Parent]- Implement Dashboard Course List E2E test #2702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Minor refactor. refs: MBL-18120 affects: Parent release note:
|
Teacher Install Page |
|
Student Install Page |
|
Native Parent Install Page |
tamaskozmer
approved these changes
Jan 22, 2025
| Log.d(ASSERTION_TAG, "Assert that the '${parent.name}' parent user has logged in.") | ||
| leftSideNavigationDrawerPage.assertUserLoggedIn(parent) | ||
|
|
||
| val selectedShortName = if (student.sortableName.compareTo(student2.sortableName) < 0) { |
There was a problem hiding this comment.
If we seed more student and we can't determine which student is selected initially I would suggest abstracting this logic somewhere. This might be helpful later in other tests as well. Maybe have a function for initiallySelectedStudent or otherStudent.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement Course List E2E test for native Parent app.
Minor refactor.
refs: MBL-18120
affects: Parent
release note: