Skip to content

Commit

Permalink
Fix webpack/react/uglify-es performance regression
Browse files Browse the repository at this point in the history
Closes: CORE-2126

See my comment on the github thread for details
facebook/react#13987 (comment)

Test plan:
* try canvas in a production environment
* all pages that use React components should feel faster

Change-Id: I3d9279784ef38bff1342ab6d20bbfefa697c92b2
Reviewed-on: https://gerrit.instructure.com/171633
Tested-by: Jenkins
Reviewed-by: Clay Diffrient <[email protected]>
QA-Review: Ryan Shaw <[email protected]>
Product-Review: Ryan Shaw <[email protected]>
  • Loading branch information
ryankshaw committed Nov 8, 2018
1 parent 98a4d3c commit 4d0f3aa
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion webpack.production.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,8 @@ if (!process.env.JS_BUILD_NO_UGLIFY) {
parallel: true,
uglifyOptions: {
compress: {
sequences: false // prevents it from combining a bunch of statments with ","s so it is easier to set breakpoints
sequences: false, // prevents it from combining a bunch of statments with ","s so it is easier to set breakpoints
reduce_funcs: false // works around this bug: https://github.com/facebook/react/issues/13987#issuecomment-437100945
},
ecma: 5,
output: {
Expand Down

0 comments on commit 4d0f3aa

Please sign in to comment.