Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better toString on custom exceptions #140

Merged
merged 4 commits into from
Dec 12, 2023
Merged

Better toString on custom exceptions #140

merged 4 commits into from
Dec 12, 2023

Conversation

alexlapa
Copy link
Contributor

@alexlapa alexlapa commented Dec 12, 2023 •
edited by tyranron
Loading

Synopsis

This PR adds better toString for custom exceptions

Checklist

  • Created PR:
    • In draft mode
    • Name contains Draft: prefix
    • Name contains issue reference
    • Has k:: labels applied
    • Has assignee
  • Documentation is updated (if required)
  • Tests are updated (if required)
  • Changes conform code style
  • CHANGELOG entry is added (if required)
  • FCM (final commit message) is posted
    • and approved
  • Review is completed and changes are approved
  • Before merge:
    • Milestone is set
    • PR's name and description are correct and up-to-date
    • Draft: prefix is removed
    • All temporary labels are removed

@alexlapa alexlapa added enhancement Improvement of existing features or bugfix k::api Related to API (application interface) labels Dec 12, 2023
@alexlapa alexlapa self-assigned this Dec 12, 2023
@alexlapa alexlapa marked this pull request as ready for review December 12, 2023 10:07
@alexlapa
Copy link
Contributor Author

FCM:

Improve `toString()` on custom Dart exceptions (#140)

@alexlapa alexlapa requested a review from tyranron December 12, 2023 11:31
@tyranron tyranron merged commit 9aac405 into master Dec 12, 2023
52 checks passed
@tyranron tyranron deleted the dart-exceptions-tostring branch December 12, 2023 15:09
@tyranron tyranron changed the title Draft: Better toString on custom exceptions Better toString on custom exceptions Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tyranron tyranron tyranron approved these changes

Assignees

@alexlapa alexlapa

Labels
enhancement Improvement of existing features or bugfix k::api Related to API (application interface)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexlapa @tyranron