-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Dart invoking medea-jason on non-main thread #197
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexlapa
added
enhancement
Improvement of existing features or bugfix
k::refactor
Refactoring, technical debt elimination and other improvements of existing code base
platform::android
Specific to Android platform
platform::ios
Specific to iOS platform
platform::windows
Specific to Windows platform
platform::linux
Specific to Linux platform
platform::macos
Specific to macOS platform
labels
Dec 27, 2024
FCM
|
evdokimovs
approved these changes
Dec 30, 2024
tyranron
approved these changes
Dec 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
Improvement of existing features or bugfix
k::design
Related to overall design and/or architecture
k::refactor
Refactoring, technical debt elimination and other improvements of existing code base
platform::android
Specific to Android platform
platform::ios
Specific to iOS platform
platform::linux
Specific to Linux platform
platform::macos
Specific to macOS platform
platform::windows
Specific to Windows platform
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revealed in #193
Synopsis
From #193 it seems that at least two different threads call executor
task_wake
. medea-jason is designed to work in a single threaded environment so that might end bad.Solution
It was tracked that second thread appears at
callback_finalizer
and that makes sense since Dart does not guarantee that this callback will only be called on a main thread:Checklist
k::
labels applied