Add secretKeyRef in manifest (#94)

int128 · Feb 7, 2021 · 555121d · 555121d
1 parent 67d8612
commit 555121d
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 7 deletions.
diff --git a/config/manager/manager.yaml b/config/manager/manager.yaml
@@ -27,6 +27,13 @@ spec:
         - /manager
         args:
         - --enable-leader-election
+        env:
+        - name: GITHUB_TOKEN
+          valueFrom:
+            secretKeyRef:
+              name: controller-manager
+              key: GITHUB_TOKEN
+              optional: true
         image: controller:latest
         name: manager
         resources:

diff --git a/e2e_test/Makefile b/e2e_test/Makefile
@@ -58,7 +58,7 @@ deploy-argocd: cluster
 deploy-controller: cluster build-controller
 	kind load docker-image controller:latest --name $(CLUSTER_NAME)
 	kustomize build controller | kubectl apply -f -
-	-kubectl -n argocd-commenter-system create secret generic argocd-commenter-secret --from-literal="GITHUB_TOKEN=$(GITHUB_TOKEN)"
+	-kubectl -n argocd-commenter-system create secret generic controller-manager --from-literal="GITHUB_TOKEN=$(GITHUB_TOKEN)"
 	kubectl -n argocd-commenter-system rollout status deployment argocd-commenter-controller-manager
 
 build-controller:

diff --git a/e2e_test/controller/deployment/argocd-commenter-controller-manager.yaml b/e2e_test/controller/deployment/argocd-commenter-controller-manager.yaml
@@ -10,9 +10,3 @@ spec:
         - name: manager
           # https://kind.sigs.k8s.io/docs/user/quick-start/#loading-an-image-into-your-cluster
           imagePullPolicy: Never
-          env:
-            - name: GITHUB_TOKEN
-              valueFrom:
-                secretKeyRef:
-                  name: argocd-commenter-secret
-                  key: GITHUB_TOKEN