feat: terminate watch mode when all resources complete #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Verifying against |
aidenkeating
reviewed
Jul 6, 2020
cmd/cli/cleanup.go
Outdated
| for { | ||
| newReport, err := clusterService.DeleteResourcesForCluster(clusterId, map[string]string{}, dryRun) | ||
| if watch { | ||
| err := wait.PollImmediate(30*time.Second, 20*time.Minute, func() (bool, error) { |
There was a problem hiding this comment.
Did we test this against a full RHMI install? Is 20 minutes a safe enough timeout?
There was a problem hiding this comment.
Very good point. I used 20 minutes because it was the number mentioned in the original JIRA. I'll attempt it against a full cluster.
dimitraz
reviewed
Jul 6, 2020
| err := wait.PollImmediate(30*time.Second, watchTimeout, func() (bool, error) { | ||
| var currentReport *clusterservice.Report | ||
| newReport := runCleanupCommand(clusterService, clusterId, dryRun) | ||
| if currentReport == nil { |
There was a problem hiding this comment.
Will currentReport not always be nil? Or is it being set somewhere else?
There was a problem hiding this comment.
Oh it's set the next loop around.. Nevermind :)
aidenkeating
approved these changes
Jul 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
aka "and now my watch has ended" ;)
Verification Steps
./cluster-service cleanup <cluster-id> --dry-run=false --watchVerify that: