Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add initial unit tests for the aws client and the rds engine #2

Merged
merged 2 commits into from
Mar 2, 2020

Conversation

aidenkeating
Copy link
Contributor

add basic tests for the existing aws functionality, this includes
the aws client logic and the rds action engine logic

verification:

  • run 'make test/unit'
  • ensure the tests complete successfully

Aiden Keating added 2 commits February 27, 2020 15:19
add basic tests for the existing aws functionality, this includes
the aws client logic and the rds action engine logic

verification:
- run 'make test/unit'
- ensure the tests complete successfully
this commit adds a github workflow for pushing and for releasing
the repo

verification:
- ensure github picks up on the workflows and runs tests
Copy link
Contributor

@hubeadmin hubeadmin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aidenkeating aidenkeating merged commit 95cd342 into master Mar 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants