add s3 bucket deletion via an action engine #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
March 10, 2020 22:51
add a new aws action engine for deleting s3 buckets associated with a cluster. this s3 action engine uses the aws tagging functionality to filter only the s3 buckets that match the cluster id and additional specified tags on the aws side instead of performing filtering on the client side. this commit also includes hack files to help with s3 manual testing and future development. verification: - run 'make build/cli' - run './hack/aws-s3-create-bucket.sh' - run './cli cleanup cluster-service --region=us-east-1 --dry-run=false' - ensure s3 buckets are removed for the cluster
the action engine interface is very vague. to help give some more context on what the interface is for, the name has been changed in this commit to cluster resource manager. additionally, a refactor of rds.go and s3.go in the aws package have been refactored to include the 'manager_' prefix in the file name. verification: - run 'make test/unit' - ensure tests pass successfully
add basic unit tests for s3 resource manager. verification: - run 'make test/unit' - ensure all tests pass
add watch flag to the cli, the flag can be used by either specifying '--watch' or '-w' to the cli. verification: - run 'make build/cli' - run './cli cleanup test -w --verbose' - ensure the cli loops indefinitely - run './cli cleanup test' - ensure the cli exits after one run
complete basic support for the watch flag in the cli. add the concept of 'merging forward' to allow for resources that no longer exist to be treated as deleted. this merge support is an in-line merge, and will modify the existing report. verification: - run 'make test/unit' - ensure tests complete successfully
this commit performs a number of tasks: - adds an rds snapshot cluster resource manager for aws - refactor engines to resource manager terminology - add flag for only deleting specific resource types
aidenkeating
force-pushed
the
add-s3-support
branch
from
75c48d0 to
bb94ff0
Compare
add hack scripts for setting up test subnets and replication groups in aws with the correct tags required for basic manual testing. verification: - run './hack/aws-ec2-create-subnet.sh' - ensure a subnet is created in the default vpc in us-east-1 - run './hack/aws-elasticache-create-replicationgroup.sh' - ensure a replication group is created in the us-east-1 region with appropriate tags (integreatly.org/clusterID)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add a new aws action engine for deleting s3 buckets associated
with a cluster.
this s3 action engine uses the aws tagging functionality to
filter only the s3 buckets that match the cluster id and
additional specified tags on the aws side instead of performing
filtering on the client side.
this commit also includes hack files to help with s3 manual
testing and future development.
verification: