complete refactor to resource manager terminology #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
March 11, 2020 12:07
remove references to action engines completely in all aws logic. from this point on these concepts should be refered to as resource managers as it's slightly less vague. verification: - run 'make test/unit' - ensure tests pass successfully
allow ec2 subnets associated with a cluster to be deleted. this includes support for deleting subnets via the cli. verification: - run 'make build/cli' - run './hack/aws-ec2-create-subnet.sh' - run './cli cleanup cluster-service --verbose --region=us-east-1 --dry-run=false -t ec2:subnet -w' - wait for the subnet status to be 'complete' - ensure the subnet has been removed from aws ec2
ensure logging is consistent among the main fields added to each logger in resource manager logic.
this commit prevents an error from occuring in the case where a subnet has an associated resource with it. for example an rds instance. verification: - create a subnet using the hack script in this repo - create a subnet group in aws containing this new subnet - create an rds instance with the subnet group associated with it - run the cli using the cluster id 'cluster-service' in region us-east-1 with the '-w' flag set - ensure the subnet is marked as skipped - delete the rds instance - ensure after a number of reconciles that the cli marks the subnet as completed
aidenkeating
force-pushed
the
ec2-subnet-groups
branch
from
1d66236 to
0077a3d
Compare
|
Verified while verifying https://github.com/RHCloudServices/integreatly-help/pull/411 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove references to action engines completely in all aws logic.
from this point on these concepts should be refered to as resource
managers as it's slightly less vague.
verification: