Merge pull request #4 from aidenkeating/secret-format

add secret kind and version explicitly when converting
integr8ly · Jan 30, 2020 · a112b9a · a112b9a
2 parents b0523fb + cd8920b
commit a112b9a
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 0 deletions.
diff --git a/pkg/smtpdetails/smtpdetails.go b/pkg/smtpdetails/smtpdetails.go
@@ -27,6 +27,10 @@ type Client interface {
 //ConvertSMTPDetailsToSecret Format a standard set of SMTPDetails as a Kubernetes Secret
 func ConvertSMTPDetailsToSecret(smtpDetails *SMTPDetails, secretName string) *apiv1.Secret {
 	return &apiv1.Secret{
+		TypeMeta: v1.TypeMeta{
+			Kind:       SecretGVKKind,
+			APIVersion: SecretGVKVersion,
+		},
 		ObjectMeta: v1.ObjectMeta{
 			Name: secretName,
 		},

diff --git a/pkg/smtpdetails/smtpdetails_test.go b/pkg/smtpdetails/smtpdetails_test.go
@@ -47,6 +47,10 @@ func TestConvertSMTPDetailsToSecret(t *testing.T) {
 				secretName:  "testSec",
 			},
 			want: &apiv1.Secret{
+				TypeMeta: v1.TypeMeta{
+					Kind:       SecretGVKKind,
+					APIVersion: SecretGVKVersion,
+				},
 				ObjectMeta: v1.ObjectMeta{
 					Name: "testSec",
 				},

diff --git a/pkg/smtpdetails/strings.go b/pkg/smtpdetails/strings.go
@@ -13,4 +13,8 @@ const (
 	SecretKeyUsername = "username"
 	//SecretKeyPassword Default secret data key for SMTP auth password
 	SecretKeyPassword = "password"
+	//SecretGVKKind GVK Kind of an OpenShift/Kubernetes Secret
+	SecretGVKKind = "Secret"
+	//SecretGVKVersion GVK Version of an OpenShift/Kubernetes Secret
+	SecretGVKVersion = "v1"
 )