refactor code comments to align with spec better

integritychain · Oct 28, 2024 · 346b6f8 · 346b6f8
1 parent e9553c2
commit 346b6f8
Show file tree

Hide file tree

Showing 9 changed files with 434 additions and 310 deletions.
diff --git a/ct_cm4/Cargo.toml b/ct_cm4/Cargo.toml
@@ -1,6 +1,6 @@
 [package]
 name = "fips204-ct_cm4"
-version = "0.4.3"
+version = "0.4.4"
 authors = ["Eric Schorn <[email protected]>"]
 description = "Cortex-M4 testbench for FIPS 204 (draft) ML-DSA"
 edition = "2021"

diff --git a/dudect/Cargo.toml b/dudect/Cargo.toml
@@ -1,6 +1,6 @@
 [package]
 name = "fips204-dudect"
-version = "0.4.3"
+version = "0.4.4"
 authors = ["Eric Schorn <[email protected]>"]
 description = "Dudect testbench for FIPS 204 (draft) ML-DSA"
 edition = "2021"

diff --git a/fuzz/Cargo.toml b/fuzz/Cargo.toml
@@ -1,6 +1,6 @@
 [package]
 name = "fips204-fuzz"
-version = "0.4.3"
+version = "0.4.4"
 authors = ["Eric Schorn <[email protected]>"]
 description = "Fuzz harness for FIPS 204 (draft) ML-DSA"
 edition = "2021"

diff --git a/src/lib.rs b/src/lib.rs
diff --git a/src/ml_dsa.rs b/src/ml_dsa.rs
diff --git a/src/types.rs b/src/types.rs
@@ -25,7 +25,6 @@ pub struct PrivateKey<const K: usize, const L: usize> {
     pub(crate) s_hat_1_mont: [T; L],
     pub(crate) s_hat_2_mont: [T; K],
     pub(crate) t_hat_0_mont: [T; K],
-//    pub(crate) cap_a_hat: [[T; L]; K],
 }
 
 
@@ -37,7 +36,6 @@ pub struct PrivateKey<const K: usize, const L: usize> {
 #[repr(align(8))]
 pub struct PublicKey<const K: usize, const L: usize> {
     pub(crate) rho: [u8; 32],
-//    pub(crate) cap_a_hat: [[T; L]; K],
     pub(crate) tr: [u8; 64],
     pub(crate) t1_d2_hat_mont: [T; K],
 }

diff --git a/tests/nist_vectors/mod.rs b/tests/nist_vectors/mod.rs
@@ -119,7 +119,7 @@ fn test_siggen() {
                     ml_dsa_44::PrivateKey::try_from_bytes(sk_bytes.clone().try_into().unwrap())
                         .unwrap();
                 //let sig_act = sk.try_sign_with_rng(&mut rnd, &message, &[]).unwrap();
-                let sig_act = ml_dsa_44::_internal_sign(&sk, &mut rnd, &message, &[]).unwrap();
+                let sig_act = ml_dsa_44::_internal_sign(&sk, &message, &[], seed).unwrap();
                 assert_eq!(sig_exp, sig_act);
             }
 
@@ -129,7 +129,7 @@ fn test_siggen() {
                     ml_dsa_65::PrivateKey::try_from_bytes(sk_bytes.clone().try_into().unwrap())
                         .unwrap();
                 //let sig_act = sk.try_sign_with_rng(&mut rnd, &message, &[]).unwrap();
-                let sig_act = ml_dsa_65::_internal_sign(&sk, &mut rnd, &message, &[]).unwrap();
+                let sig_act = ml_dsa_65::_internal_sign(&sk, &message, &[], seed).unwrap();
                 assert_eq!(sig_exp, sig_act);
             }
 
@@ -138,7 +138,7 @@ fn test_siggen() {
                 let sk =
                     ml_dsa_87::PrivateKey::try_from_bytes(sk_bytes.try_into().unwrap()).unwrap();
                 //let sig_act = sk.try_sign_with_rng(&mut rnd, &message, &[]).unwrap();
-                let sig_act = ml_dsa_87::_internal_sign(&sk, &mut rnd, &message, &[]).unwrap();
+                let sig_act = ml_dsa_87::_internal_sign(&sk, &message, &[], seed).unwrap();
                 assert_eq!(sig_exp, sig_act);
             }
         }

diff --git a/wasm/Cargo.toml b/wasm/Cargo.toml
@@ -1,6 +1,6 @@
 [package]
 name = "fips204-wasm"
-version = "0.4.3"
+version = "0.4.4"
 authors = ["Eric Schorn <[email protected]>"]
 description = "Sample web page utilizing FIPS 204 code"
 repository = ""

diff --git a/wasm/www/package-lock.json b/wasm/www/package-lock.json