-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sample/quote: Add Makefile and README #71
Conversation
50e132d
to
6b330e4
Compare
samples/quote/Makefile
Outdated
|
||
server.json: server/Dockerfile signer.pem signer.cer | .acon/ | ||
$(DOCKER) build -t sampleserver -f $< $(PWD)/../.. | ||
$(ACONCLI) generate -i sampleserver $@ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I remember that "writableFS" in the manifest needs to be changed to "true".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does quote_server need to write disk files? If no, then we don't need writable FS.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No. Seems there is a bug of acond.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@binxing, is /run/user/0
a must directory for readonly file system?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/run
is a separate tmpfs mount that shouldn't be affected by writableFS
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mean /run/user/*
, not /run
.
samples/quote/README.md
Outdated
- The server must be started first, by | ||
|
||
```sh | ||
TCP_PORT=5555 ATD=1 ATD_KERNEL=/path/to/vmlinuz ATD_RD=/path/to/initrd.img aconcli run -ni -c:$TCP_PORT server.json |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it need a TCP port mapping between server and client?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right! Which port?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@xxu36 and @xiangquanliu, I added ATD_TCPFWD=8080:8085
. Let me know if I'm wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that's right.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, currently we are using this mapping
5399f2f
to
6ae42f0
Compare
samples/quote/Makefile
Outdated
$(OPENSSL) req -x509 -sha384 -key $< -out $@ -outform der -subj /CN=self-signed-$< | ||
|
||
client/sampleclient: | ||
$(GO) -C $(@D) build -v |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if it is better to build a static linked binary. For example, to build it in development environment and test in EMR environment - may cause link errors.
Signed-off-by: Cedric Xing <[email protected]>
6ae42f0
to
d7f6407
Compare
No description provided.