-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds Huggingface GenAI container build specs into pytorch/Dockerfile and pytorch/docker-compose.yaml #146
Adds Huggingface GenAI container build specs into pytorch/Dockerfile and pytorch/docker-compose.yaml #146
Conversation
Dependency ReviewThe following issues were found:
License Issuespytorch/hf-genai-requirements.txt
OpenSSF ScorecardScorecard details
Scanned Manifest Files |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- What is the public name of this container going to be?
intel/intel-optimized-pytorch:2.3.0-pip-hf-genai
? - What happens to
workflows/charts/huggingface-llm
? Does that container go away in favor of this one or are they different?
Please update the README.md file appropriately, this will go to Dockerhub.
@tylertitsworth The huggingface-llm container will switch to use this Gen AI container as it's base and I think the only thing it'll need is a copy of the fine tuning python script |
@dmsuehir Good to know, then the only potential conflict with this PR is #124. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Recipe looks good, there are a few kinks to work out that have been helpfully suggested by your coworkers. Please write some tests in pytorch/tests/tests.yaml
that validate this solution. Make sure no test runs for more than 5-10 minutes.
Next part is the docs, which you can choose to split into another PR if you want. Let me know what you decide.
Most important thing is that all of the CI is green.
I'll do the docs too in this PR. I'll update you |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All of your changes look fine, I have a couple comments, but since this is dependent on #124 we need to wait on merging this.
Signed-off-by: tylertitsworth <[email protected]>
3bb90f9
to
c16761f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@HarshaRamayanam I had to squash your commits because the history was getting complex, feel free to re-contribute those commits however you want.
Signed-off-by: Harsha Ramayanam <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few minor things, I have locally validated your image and if you're happy with it we can merge today.
Co-authored-by: Tyler Titsworth <[email protected]> Signed-off-by: Harsha Ramayanam <[email protected]>
Co-authored-by: Tyler Titsworth <[email protected]> Signed-off-by: Harsha Ramayanam <[email protected]>
Co-authored-by: Tyler Titsworth <[email protected]> Signed-off-by: Harsha Ramayanam <[email protected]>
…and pytorch/docker-compose.yaml (#146) Signed-off-by: tylertitsworth <[email protected]> Signed-off-by: Harsha Ramayanam <[email protected]> Co-authored-by: tylertitsworth <[email protected]> Co-authored-by: Tyler Titsworth <[email protected]> Signed-off-by: Dina Suehiro Jones <[email protected]>
Description
This PR adds a new entry into
pytorch/Dockerfile
for building a Huggingface GenAI container that can run a typical Generative AI model from Hugging Face. (like run_clm.py script from transformers)It also adds a new service entry in
pytorch/docker-compose.yaml
file namedhf-genai
(can be renamed in future) to build the containerAdditional files added are
Related Issue
None
Changes Made
pytorch/Dockerfile
(Modified)pytorch/docker-compose.yaml
(Modified)pytorch/generate_ssh_keys.sh
(New file)pytorch/hf-genai-requirements.txt
(New file)The code follows the project's coding standards.
No Intel Internal IP is present within the changes.
The documentation has been updated to reflect any changes in functionality.
Validation
test_runner.py
with all existing tests passing, and I have added new tests where applicable.