Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ghcr.io #179

Merged
merged 5 commits into from
Jun 25, 2024
Merged

ghcr.io #179

merged 5 commits into from
Jun 25, 2024

Conversation

tylertitsworth
Copy link
Contributor

@tylertitsworth tylertitsworth commented Jun 25, 2024 •
edited
Loading

Description

Use private github registry

Related Issue

n/a

Changes Made

  • switch to exclusively building on ubuntu-latest
  • Modify secrets to use github private registry
  • The code follows the project's coding standards.
  • No Intel Internal IP is present within the changes.
  • The documentation has been updated to reflect any changes in functionality.

Validation

https://github.com/intel/ai-containers/actions/runs/9669568703/job/26676459368

  • I have tested any changes in container groups locally with test_runner.py with all existing tests passing, and I have added new tests where applicable.

@tylertitsworth tylertitsworth added the WIP Work in Progress label Jun 25, 2024
@tylertitsworth tylertitsworth self-assigned this Jun 25, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 25, 2024 •
edited
Loading

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files

@tylertitsworth tylertitsworth added Review and removed WIP Work in Progress labels Jun 25, 2024
sharvil10
sharvil10 approved these changes Jun 25, 2024
View reviewed changes
Copy link
Contributor

@sharvil10 sharvil10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tylertitsworth tylertitsworth merged commit f5eadcc into main Jun 25, 2024
9 checks passed
@tylertitsworth tylertitsworth deleted the tylertitsworth/ghcr-io branch June 25, 2024 21:42
ma-pineda pushed a commit that referenced this pull request Jun 28, 2024
@ma-pineda
ghcr.io (#179)
c057de8 
Signed-off-by: Tyler Titsworth <[email protected]>
Signed-off-by: ma-pineda <[email protected]>
ma-pineda pushed a commit that referenced this pull request Jun 28, 2024
@ma-pineda
ghcr.io (#179)
386baf9 
Signed-off-by: Tyler Titsworth <[email protected]>
Signed-off-by: ma-pineda <[email protected]>
ma-pineda pushed a commit that referenced this pull request Jun 28, 2024
@ma-pineda
ghcr.io (#179)
bc2cbaa 
Signed-off-by: Tyler Titsworth <[email protected]>
Signed-off-by: ma-pineda <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sharvil10 sharvil10 sharvil10 approved these changes

@jitendra42 jitendra42 Awaiting requested review from jitendra42 jitendra42 is a code owner

Assignees

@tylertitsworth tylertitsworth

Labels
Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tylertitsworth @sharvil10