Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Merge Check to action-wait-for-check #81

Merged
merged 1 commit into from
Jun 3, 2024

Conversation

tylertitsworth
Copy link
Contributor

Description

Merge Groups can't merge because coverage can't be detected by the method in the current workflow Merge Check that gives the status check.

Related Issue

n/a

Changes Made

Title

  • The code follows the project's coding standards.
  • No Intel Internal IP is present within the changes.
  • The documentation has been updated to reflect any changes in functionality.

Validation

Must merge first.

  • I have tested any changes in container groups locally with test_runner.py with all existing tests passing, and I have added new tests where applicable.

Copy link

github-actions bot commented Jun 3, 2024

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails
actions/fountainhead/action-wait-for-check 5a908a24814494009c4bb27c242ea38c93c593be 🟢 3.2
Details
CheckScoreReason
Code-Review⚠️ 2Found 3/15 approved changesets -- score normalized to 2
Maintained⚠️ 12 commit(s) and 0 issue activity found in the last 90 days -- score normalized to 1
CII-Best-Practices⚠️ 0no effort to earn an OpenSSF best practices badge detected
License🟢 10license file detected
Signed-Releases⚠️ -1no releases found
Dangerous-Workflow🟢 10no dangerous workflow patterns detected
Binary-Artifacts🟢 10no binaries found in the repo
Packaging⚠️ -1packaging workflow not detected
Token-Permissions⚠️ 0detected GitHub workflow tokens with excessive permissions
Branch-Protection⚠️ 0branch protection not enabled on development/release branches
Fuzzing⚠️ 0project is not fuzzed
Security-Policy⚠️ 0security policy file not detected
SAST⚠️ 0SAST tool is not run on all commits -- score normalized to 0
Pinned-Dependencies🟢 3dependency not pinned by hash detected -- score normalized to 3
Vulnerabilities🟢 37 existing vulnerabilities detected
actions/lewagon/wait-on-check-action ccfb013c15c8afb7bf2b7c028fb74dc5a068cccc 🟢 4.5
Details
CheckScoreReason
Code-Review🟢 4Found 8/19 approved changesets -- score normalized to 4
Maintained🟢 44 commit(s) and 1 issue activity found in the last 90 days -- score normalized to 4
CII-Best-Practices⚠️ 0no effort to earn an OpenSSF best practices badge detected
License🟢 10license file detected
Binary-Artifacts🟢 10no binaries found in the repo
Packaging⚠️ -1packaging workflow not detected
Dangerous-Workflow🟢 10no dangerous workflow patterns detected
Signed-Releases⚠️ -1no releases found
Token-Permissions⚠️ 0detected GitHub workflow tokens with excessive permissions
Branch-Protection⚠️ -1internal error: error during branchesHandler.setup: internal error: githubv4.Query: Resource not accessible by integration
Fuzzing⚠️ 0project is not fuzzed
Security-Policy⚠️ 0security policy file not detected
Vulnerabilities🟢 91 existing vulnerabilities detected
SAST⚠️ 0SAST tool is not run on all commits -- score normalized to 0
Pinned-Dependencies⚠️ 0dependency not pinned by hash detected -- score normalized to 0

Scanned Manifest Files

.github/workflows/merge_check.yaml

Copy link
Contributor

@jitendra42 jitendra42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tylertitsworth tylertitsworth added this pull request to the merge queue Jun 3, 2024
Merged via the queue into main with commit 20510be Jun 3, 2024
9 checks passed
@tylertitsworth tylertitsworth deleted the tylertitsworth/swap-merge-check-action branch June 3, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants