-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Address compiler warnings on ppc64le and s390x #310
Open
ellert
wants to merge
1
commit into
intel:master
Choose a base branch
from
ellert:ppc64le-s390x-warnings
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ellert
commented
Jan 18, 2025
igzip/igzip_icf_body.c:7:1: warning: type of 'gen_icf_map_lh1' does not match original declaration [-Wlto-type-mismatch] 7 | gen_icf_map_lh1(struct isal_zstream *, struct deflate_icf *, uint32_t); | ^ igzip/igzip_base_aliases.c:177:1: note: return value type mismatch 177 | gen_icf_map_lh1(struct isal_zstream *stream, struct deflate_icf *matches_icf_lookup, | ^ igzip/igzip_base_aliases.c:177:1: note: type 'void' should match type 'uint64_t' igzip/igzip_base_aliases.c:177:1: note: 'gen_icf_map_lh1' was previously declared here igzip/igzip_base_aliases.c:177:1: note: code may be misoptimized unless '-fno-strict-aliasing' is used igzip/igzip_icf_body.c:9:1: warning: type of 'set_long_icf_fg' does not match original declaration [-Wlto-type-mismatch] 9 | set_long_icf_fg(uint8_t *, uint64_t, uint64_t, struct deflate_icf *); | ^ igzip/igzip_base_aliases.c:170:1: note: type mismatch in parameter 2 170 | set_long_icf_fg(uint8_t *next_in, uint8_t *end_in, struct deflate_icf *match_lookup, | ^ igzip/igzip_base_aliases.c:170:1: note: 'set_long_icf_fg' was previously declared here igzip/igzip_base_aliases.c:170:1: note: code may be misoptimized unless '-fno-strict-aliasing' is used igzip/igzip_base_aliases.c:62:1: warning: type of 'set_long_icf_fg_base' does not match original declaration [-Wlto-type-mismatch] 62 | set_long_icf_fg_base(uint8_t *next_in, uint8_t *end_in, struct deflate_icf *match_lookup, | ^ igzip/igzip_icf_body.c:34:1: note: type mismatch in parameter 2 34 | set_long_icf_fg_base(uint8_t *next_in, uint64_t processed, uint64_t input_size, | ^ igzip/igzip_icf_body.c:34:1: note: 'set_long_icf_fg_base' was previously declared here igzip/igzip_icf_body.c:34:1: note: code may be misoptimized unless '-fno-strict-aliasing' is used igzip/igzip_base_aliases.c:54:1: warning: type of 'adler32_base' does not match original declaration [-Wlto-type-mismatch] 54 | adler32_base(uint32_t init, const unsigned char *buf, uint64_t len); | ^ igzip/adler32_base.c:34:1: note: type mismatch in parameter 3 34 | adler32_base(uint32_t adler32, uint8_t *start, uint32_t length) | ^ igzip/adler32_base.c:34:1: note: type 'uint32_t' should match type 'uint64_t' igzip/adler32_base.c:34:1: note: 'adler32_base' was previously declared here igzip/adler32_base.c:34:1: note: code may be misoptimized unless '-fno-strict-aliasing' is used Signed-off-by: Mattias Ellert <[email protected]>
ellert
force-pushed
the
ppc64le-s390x-warnings
branch
2 times, most recently
from
January 21, 2025 22:44
5ee2d03
to
dacc81b
Compare
ellert
changed the title
Adderss compiler warnings on ppc64le and s390x
Address compiler warnings on ppc64le and s390x
Jan 21, 2025
Hi @ellert. Could you share the compiler you are using and the command line used to compile? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.