Remove all references to pccs service #1057
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The PCCS code was deleted in the DCAP 1.22 release that SGX references, resulting in a failure to build the installers for DCAP / TDX. e.g. $ /usr/bin/make -I linux/installer/common/psw-dcap -f linux/installer/common/psw-dcap/Makefile SRCDIR=. DESTDIR=build/vroot/psw install ...snip... python /var/home/berrange/rpmbuild/BUILD/linux-sgx-sgx_2.25_reproducible/linux/installer/common/gen_source/copy_source.py --bom-file /var/home/berrange/rpmbuild/BUILD/linux-sgx-sgx_2.25_reproducible/linux/installer/common/psw-dcap/BOM_install/sgx-dcap-pccs.txt --src-path . --dst-path build/pkgroot/sgx-dcap-pccs Error: src directory/file ./external/dcap_source/QuoteGeneration/pccs/config/default.json does not exist! make: *** [linux/installer/common/psw-dcap/Makefile:195: pre_sgx-dcap-pccs] Error 1 Remove all traces of PCCS from the installer. Signed-off-by: Daniel P. Berrangé <[email protected]>
xiangquanliu
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PCCS code was deleted in the DCAP 1.22 release that SGX references, resulting in a failure to build the installers for DCAP / TDX. e.g.
Remove all traces of PCCS from the installer.
NB: this does not attempt to put any "Obsoletes: sgx-dcap-pccs" line into any remaining RPM to cause 'sgx-dcap-pccs' to be uninstalled on package update, since it isn't clear what (if any) upgrade story there is wrt the removal of PCCS, for users whom were relying on it previously.