-
Notifications
You must be signed in to change notification settings - Fork 549
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
headers: Add macro to print error code as string #366
base: main
Are you sure you want to change the base?
Conversation
* Adds a PRINT_SGX_STATUS macro to sgx_error.h which prints the sgx_status_t as a string.
Generated with: (
echo -e '#define PRINT_SGX_STATUS(FILE_STRUCT, STATUS_T) \\\n switch (STATUS_T) {\\';
for error in $(grep -E '=.*SGX_MK_ERROR' /opt/intel/sgxsdk/include/sgx_error.h | awk '{print $1}' | sed 's/=//g'); do
printf ' case %s:\\\n fprintf(FILE_STRUCT, "Error: %s\\n");\\\n break;\\\n' $error $error;
done;
echo -e ' }'
) |
maybe this would be better as something similar to |
Might be even better to make it similar to |
Ya that is probably a better option, I think that's what was started in #346 perhaps that PR should be one PR introducing the |
Something similar is going on in the examples linux-sgx/SampleCode/SampleEnclave/App/App.cpp Lines 55 to 70 in a85fbe9
|
Hello, I was disinclined to continue working on my pull request after the comment from the Intel member himself saying that maybe it did not help much. And I still maintain my position, I think it is very important and avoids many lines of unnecessary codes that will be inserted in each enclave. |
I agree. As I posted above something similar was done in the sample enclave code. If its useful there then it is of course useful and instead of duplicating that functionality it should be a part of the SDK. |
I believe that it's a really useful patch. |
PRINT_SGX_STATUS
macro to sgx_error.h which printsthe
sgx_status_t
as a string.