-
Notifications
You must be signed in to change notification settings - Fork 752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] Add CI workflow to run compute-benchmarks on incoming syclos PRs #14454
base: sycl
Are you sure you want to change the base?
Conversation
@uditagarwal97 @aelovikov-intel Mind if I ask for another review? Thanks in advance! |
shell: bash | ||
run: | | ||
# DO NOT use inputs.lookback_days directly, only use SANITIZED_TIMESTAMP. | ||
SANITIZED_LOOKBACK_DAYS="$(echo '${{ inputs.lookback_days }}' | grep -o "^[0-9]$")" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we prohibit >= 10 days?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In that case, why isn't type: number
enough?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It probably is, but I've learned that github in itself is a vulnerability (e.g. failure to scrub secrets, injections via branch names); This doesn't seem too extreme, and I'd rather not rely on github if it's convenient.
find ./llvm-ci-perf-results -mindepth 3 -maxdepth 3 -type d ! -path '*.git*' | | ||
while read -r dir; do | ||
test_name="$(basename "$dir")" | ||
python ./devops/scripts/benchmarking/aggregate.py ./devops "$test_name" "$dir" "$SANITIZED_TIMESTAMP" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we calculate it here instead of making it part of the results repo calculated on each upload?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a good point; I think there was a discussion long time ago, and the conclusion was that all code should be stored in this repo, although I forget why this was done. Let me address this at the next meeting.
Co-authored-by: aelovikov-intel <[email protected]>
This PR:
The current plan is to enable this benchmark to run nightly in order to catch regressions, although there is potential for this workflow to be used in precommit. As a result, a lot of components in this workflow are either separate reusable components, or directly written with precommit in mind. The current benchmarking workflow functions as so:
The workflows are fully configurable via benchmark-ci.conf; enabled compute-benchmarks tests can be configured via enabled_tests.conf.
Feel free to test out the workflow via manual dispatches of sycl-linux-run-tests.yml on branch benchmarking-workflow, but be aware that the run currently will always fail, as Github repository secrets are not yet added.