Remove sycl 1.2.1 code #16118
Merged
Remove sycl 1.2.1 code #16118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dklochkov-emb
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
dklochkov-emb
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
| @@ -68,7 +68,7 @@ | |||
| // 3300+ lines of code | |||
|
|
|||
| // SYCL_LANGUAGE_VERSION is 4 digit year followed by 2 digit revision | |||
| #if !SYCL_LANGUAGE_VERSION || SYCL_LANGUAGE_VERSION < 202001 | |||
There was a problem hiding this comment.
SYCL_LANGUAGE_VERSION is a compiler-provided macro, meaning that the only situation this #if can be taken is when SYCL headers are used with 3rd-party host compiler. I don't know why would we need a different API in that case - most likely this condition is some kind of legacy code and I would completely drop __SYCL_NONCONST_FUNCTOR__ and all its uses (meaning _KERNELFUNCPARAM_TYPE as well).
dklochkov-emb
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
dklochkov-emb
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
dklochkov-emb
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
@AlexeySachkov Please, review changes |
@dklochkov-emb, I recommend using GitHub UI to request review:
This will add your PR to the reviewer's dashboard https://github.com/pulls/review-requested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove 1.2.1 code as mentioned in #15890