[SYCL][Fusion] Fix kernel fusion passes tests #7719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexeySachkov
approved these changes
Dec 9, 2022
| // Name of the fused kernel. | ||
| auto *KernelName = dyn_cast<MDString>(MD->getOperand(0).get()); | ||
| // First metadata operand should be the fused kernel name. | ||
| auto *KernelName = cast<MDString>(MD->getOperand(0).get()); | ||
| assert(KernelName && |
There was a problem hiding this comment.
Just a note that this assert isn't needed anymore, because it exists within cast: that one will fail first and we won't see our custom message anyway.
| @@ -74,7 +72,7 @@ static Function *createMaskedFunction(const BitVector &Mask, Function *F) { | |||
| // Copy metadata. | |||
| SmallVector<std::pair<unsigned, MDNode *>> MDs; | |||
| F->getAllMetadata(MDs); | |||
| for (auto MD : MDs) { | |||
| for (auto &MD : MDs) { | |||
There was a problem hiding this comment.
Please note that I haven't thoroughly reviewed the rest of for (auto ...) loops (because the patch is quite huge), so there might be similar excessive copies somewhere else
Signed-off-by: Lukas Sommer <[email protected]>
sommerlukas
force-pushed
the
kernel-fusion/sixth-patch
branch
from
e0a191b to
e2ba7dc
Compare
victor-eds
approved these changes
Dec 9, 2022
|
@intel/llvm-gatekeepers This patch is ready to be merged, could you please merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix tests for kernel fusion passes in static builds by using correct library, loadable by
opt, for tests.Also fixes post-commit feedback from @AlexeySachkov in #7661.
Signed-off-by: Lukas Sommer [email protected]