This repository has been archived by the owner on Aug 30, 2024. It is now read-only.
[BesTLA] AVX2: Use loaded registers of B. #151
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Small performance patch for AVX2.
Description
It appears the B registers are loaded, but the FMA uses the same pointers for B, rather than the registers that have been loaded?
Expected Behavior & Potential Risk
On SPR, with AVX512/AMX disabled, I see a performance improvement for prefill and decode:
How has this PR been tested?
See above.
Dependency Change?
None.