Epctx node base path fix #559
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javier-intel
force-pushed
the
jemartin/epctx_base_path_fix
branch
from
64a567d to
21d9478
Compare
MayureshV1
reviewed
Feb 4, 2025
javier-intel
force-pushed
the
jemartin/epctx_base_path_fix
branch
from
21d9478 to
fb9ea15
Compare
|
Are we ok to merge this ? |
|
I have verified this fix. Can be merged! |
|
@javier-intel there were some lint issues, i have raised another pr including your commit and lint fixes to ovep-develop |
|
Why is this not yet merged ? |
|
@sfatimar Its merged PR: 569 & 571. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When creating EpContext nodes any external dependencies such as blobs are located relative to the model that contains the node. This PR fixes an issue where external dependencies were not found if session was created with a model passed from memory. In that case since the model name is empty the EP should use the session option
ep.context_file_pathto locate the base path.Motivation and Context
Fix internal bug.
HAFP-2993