This repository has been archived by the owner on Aug 20, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 78
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
1 parent
fb1e661
commit 2e629fe
Showing
2 changed files
with
36 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2e629fe
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this whole patch is ALSO superfluous and makes the review process just harder. You changed something a priori, didn't mention why and here you brought it back without justifying. Please clean up your Patch Sets before showing them for review @kalyankondapally
2e629fe
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tiagovignatti With recenet IRC discussion, I will publish a new review request with appropriate commit messages. You can go through these, if you want to get familiar with what is coming. Probably I will put up another review tomorrow.
2e629fe
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tiagovignatti It should have been more like unintended changes. Anyways ignore the commit messages for now, I will issue a new review request for this.