This repository has been archived by the owner on Aug 20, 2020. It is now read-only.
Wayland shell surface #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The patch introduces WaylandShellSurface class. It's a simple class which would create a shell surface and resposible for all it's activity. Currently, only support for TOPLEVEL is added. Support for other functionality i.e Min, Maximize, Popup, Transiant etc should be added as we support other use cases. The main consumer of this class is Window.
This is continuation of our effort to make window a container class and that it's responsibilities can be easily specified depending on the process model. This patch makes changes to internally use WaylandShellSurface.
This patch removes the usage of SetParentWindow in window. Window internally based the decision to eiher use TOPLEVEL shell type or TRANSIANT depending on existence of a ParentWindow. Now, consumer of Window class can set this explicitly using SetShellType api or while constructing window Window doesn't make any internal decisions.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.