Skip to content

Commit

Permalink
Use NotImplementedError not ValueError.
Browse files Browse the repository at this point in the history
  • Loading branch information
workingloong committed Oct 24, 2023
1 parent 929e635 commit 1e7f79c
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion dlrover/trainer/torch/elastic/checkpoint.py
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,7 @@ def init_checkpoint_manager(
max_to_keep,
)
else:
raise ValueError(f"Not support model class {model}")
raise NotImplementedError(f"Not support model class {model}")

Check warning on line 173 in dlrover/trainer/torch/elastic/checkpoint.py

View check run for this annotation

Codecov / codecov/patch

dlrover/trainer/torch/elastic/checkpoint.py#L173

Added line #L173 was not covered by tests


class LocalCheckpointManger(CheckpointManger):
Expand Down

0 comments on commit 1e7f79c

Please sign in to comment.