Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the checkpoint name to load for DDP. #1034

Conversation

workingloong
Copy link
Collaborator

What changes were proposed in this pull request?

Fix to checkpoint name to load for DDP.

Why are the changes needed?

All ranks of DDP should load the checkpoint of "rank_0.pt".

Does this PR introduce any user-facing change?

No.

How was this patch tested?

UT.

Copy link

codecov bot commented Mar 15, 2024

Codecov Report

Attention: Patch coverage is 91.66667% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 78.53%. Comparing base (38fee4f) to head (8df90a5).

Files Patch % Lines
...rover/trainer/torch/flash_checkpoint/ddp_engine.py 87.50% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1034   +/-   ##
=======================================
  Coverage   78.52%   78.53%           
=======================================
  Files         187      187           
  Lines       17329    17336    +7     
=======================================
+ Hits        13608    13615    +7     
  Misses       3721     3721           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@workingloong workingloong merged commit 3157af7 into intelligent-machine-learning:master Mar 15, 2024
13 checks passed
@workingloong workingloong deleted the fix-ddp-load-ckpt branch March 18, 2024 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant