Support http communication implement for DLRover Master and Agent. #1429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # dlrover/python/master/servicer.py # dlrover/python/util/common_util.py
# Conflicts: # dlrover/python/elastic_agent/torch/training.py
BalaBalaYi
added
do not merge
BalaBalaYi
requested review from
workingloong,
samplise,
majieyue and
nash635
as code owners
# Conflicts: # dlrover/python/common/constants.py # dlrover/python/tests/test_utils.py # scripts/ci_install.sh
# Conflicts: # dlrover/python/master/args.py # dlrover/python/tests/test_args.py
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1429 +/- ##
==========================================
+ Coverage 81.22% 81.30% +0.08%
==========================================
Files 238 240 +2
Lines 23169 23523 +354
==========================================
+ Hits 18818 19126 +308
- Misses 4351 4397 +46 ☔ View full report in Codecov by Sentry. |
|
It is very meaningful job. Can we remove the grpc in the following verison? |
Maybe. We need more time and practice to verify the performance, reliability, flexibility, etc., of the HTTP approach. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Why are the changes needed?
#1366
Does this PR introduce any user-facing change?
User can specify which service to use for communication between the master and agent by using the parameter
--service_type=(http/grpc). For details, please refer: dlrover/docs/deployment/argument.md.How was this patch tested?
UT + training with grpc type service + training with http type service.