Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

waiting when check_fault_nodes return NO_INIT #1440

Merged

Conversation

majieyue
Copy link
Collaborator

What changes were proposed in this pull request?

check_fault_nodes will cover NetworkFailureReason.NO_INIT situation

Why are the changes needed?

check_fault_nodes will return None and the reason is NO_INIT. client should keep waiting.

Does this PR introduce any user-facing change?

No

How was this patch tested?

UT

Copy link

codecov bot commented Jan 15, 2025

Codecov Report

Attention: Patch coverage is 91.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 81.19%. Comparing base (7ba180c) to head (8ed6ed7).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
dlrover/python/elastic_agent/master_client.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1440      +/-   ##
==========================================
- Coverage   81.20%   81.19%   -0.01%     
==========================================
  Files         238      238              
  Lines       23169    23173       +4     
==========================================
+ Hits        18815    18816       +1     
- Misses       4354     4357       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@majieyue majieyue merged commit 7257b60 into intelligent-machine-learning:master Jan 15, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants