-
Notifications
You must be signed in to change notification settings - Fork 294
Tasks don't reflect changes to plugin config #1222
Comments
What's happening here is when a new task is created, the workflow ends up being a pointer to the workflow created from the wfmap here, https://github.com/intelsdi-x/snap/blob/master/scheduler/scheduler.go#L315-L330. Further in When this occurs, any global plugin config defined gets merged into the workflow here, https://github.com/intelsdi-x/snap/blob/master/control/subscription_group.go#L238-L240. Since When |
* Adds ApplyDefaults(map[string]ctypes.ConfigValue) to ConfigDataNode * Renames ReverseMerge to ReverseMergeInPlace on ConfigDataNode * Adds ReverseMerge to ConfigDataNode returning a copy of the merged node ReverseMerge, which now returns a copy, is called when validating deps (task creation) and when loading plugins.
* Adds ApplyDefaults(map[string]ctypes.ConfigValue) to ConfigDataNode * Renames ReverseMerge to ReverseMergeInPlace on ConfigDataNode * Adds ReverseMerge to ConfigDataNode returning a copy of the merged node ReverseMerge, which now returns a copy, is called when validating deps (task creation) and when loading plugins.
To reproduce add a plugin configuration item that will be used by a given task, start the given task and then update the configuration item.
Expected result: When a task, depending on a configuration item that is not provided by the task, is changed the task should start using this new configuration item.
Actual result: The new configuration is ignored.
In the example below:
curl -X PUT --data '{"file": "/tmp/snap/snap-file2.out"}' http://localhost:8181/v1/plugins/publisher/mock-file/3/config
The text was updated successfully, but these errors were encountered: