This repository has been archived by the owner on Nov 8, 2022. It is now read-only.
Adds cache TTL and routing/caching strategy (per plugin) #639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcooklin
force-pushed
the
per-plugin-cache-ttl
branch
3 times, most recently
from
5c8f3f5 to
ac036bf
Compare
|
@geauxvirtual, @danielscottt, @tiffanyfj: This should be ready to go now. |
| return nil, serror.New(errors.New("unable to cast client to PluginCollectorClient")) | ||
| } | ||
|
|
||
| // get a metrics |
jcooklin
force-pushed
the
per-plugin-cache-ttl
branch
from
ac036bf to
1625f29
Compare
|
|
||
| type SelectablePlugin interface { | ||
| HitCount() int | ||
| LastHit() time.Time | ||
| String() string | ||
| } | ||
|
|
||
| type RoutingAndCaching interface { |
There was a problem hiding this comment.
Do you think there will be other strategy types?
I guess what I'm getting at is why not strategy.Strategy?
There was a problem hiding this comment.
Originally I had strategy.Strategy and felt it was better for readability to describe what kind of strategy was being provided.
I guess what I'm getting at is why not strategy.Strategy?
I lean towards being more descriptive. Refactoring the name in the future can happen when and if there is a need for another strategy type.
* Moves caching to the plugin pool (from plugin client) * Moves routing strategy to the plugin pool (from availableplugins) Resolves intelsdi-x#601 Partially addresses intelsdi-x#539
jcooklin
force-pushed
the
per-plugin-cache-ttl
branch
from
1625f29 to
a8ed3ae
Compare
|
LGTM |
jcooklin
added a commit
that referenced
this pull request
Dec 18, 2015
Adds cache TTL and routing/caching strategy (per plugin)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #601
Partially addresses #539