Allows references that point to parent definitions #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Introduces a `resolvedSet` structure to mark references that have been (or are currently being) resolved, to avoid infinite loops. * Resolves references eagerly before child elements are resolved. This is more in line with [the spec], which states that elements with `$ref` should be replaced entirely with the representation that they point to. [the spec]: https://tools.ietf.org/html/draft-zyp-json-schema-03#section-5.28
alindeman
force-pushed
the
selfreferencing
branch
from
3541090 to
302a2fa
Compare
cyberdelia
reviewed
Feb 26, 2017
.travis.yml
Outdated
| install: go get code.google.com/p/go.tools/cmd/cover | ||
| - 1.7 | ||
| - 1.8 | ||
| install: go get golang.org/x/tools/cmd/cover |
There was a problem hiding this comment.
You should able to drop this line entirely, cover no longer requires to be installed.
gen.go
Outdated
| @@ -18,13 +18,23 @@ func init() { | |||
| templates = template.Must(bundle.Parse(templates)) | |||
| } | |||
|
|
|||
| // resolvedSet stores a set of pointers to objects that have already been | |||
| // resolved to prevent infinite loops. | |||
| type resolvedSet map[interface{}]bool | |||
There was a problem hiding this comment.
Should this be exported, considering it's used in an exported function later?
There was a problem hiding this comment.
Yes, I think you're right. Good catch. Fixed.
|
@cyberdelia Thanks for the review. I pushed a couple of new commits based on your feedback. |
|
Lovely! Do you mind sharing a gist of the diff between your schema and the API one? It would help me plead your case on Monday. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #29
Highlights
ResolvedSetstructure to mark references that have been (or are currently being) resolved, to avoid infinite loops.$refshould be replaced entirely with the representation that they point to.Note that this still doesn't quite correctly generate the Heroku Platform API schema due to bugs in the schema itself (missing
typeinformation on some schemas). I've submitted a PR against the API to get that issue addressed, but until it's merged I've created a gist of the schema.json from my PR branch to test against.