Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DotNetStandard 2.0 Support - roadmap #90

Closed
kmossco opened this issue Nov 24, 2017 · 9 comments
Closed

DotNetStandard 2.0 Support - roadmap #90

kmossco opened this issue Nov 24, 2017 · 9 comments

Comments

@kmossco
Copy link
Contributor

kmossco commented Nov 24, 2017

Thanks to the continued feedback from the community, we have now prioritised in our roadmap to implement these bindings in DotNetStandard 2.0. We haven't yet decided if we will keep RestSharp as a dependency but we hope to have taken a decision and started implementation in the next couple of weeks.

And in order to keep this discussion more organised and cleared, I have now closed the other issues so we can continue discussing this here.

For the sake of transparency this is our plan:

  • Test internally what is the best way to achieve DotNetStandard 2.0 support and provide it continued support
  • Evaluate whether we continue using RestSharp or refactor the client with System.Net.Http

Thank you so much for everyone that submitted a PR or showed us a fork with an update on this, we really appreciate all your efforts! I'm sure we will have an update soon, and feel free to drop us a comment here if you have any concerns or questions. 👍

@nicholi
Copy link

nicholi commented Nov 29, 2017

As I stated in #43, there should be zero modifications necessary for the Library code when updating to the latest RestSharp netstandard release (which is now stable).

You can see my branch here: https://github.com/Nicholi/intercom-dotnet/tree/netstandard20
The only things you have to do is just create new csproj files really. The new netcore csproj files are VERY minimal, requires like zero effort.

The only real changes I made were for the Test projects, so that the nunit tests would also be netcore compatible (which meant upgrading to nunit 3.x), and there were a few deprecated things that had to be changed. All very minor and simple in and of themselves though.

All tests are still passing and I've had no issue using the library in netcore projects yet.

@kmossco
Copy link
Contributor Author

kmossco commented Jan 12, 2018

I have now pushed a PR that brings all this discussion into a conclusion. I also left a few notes on my train of thought in the PR comment. I'll close this when the PR is merged, but if anyone reading this could test that branch and see if it works for them it would be greatly appreciated! 🎉

@neooleg
Copy link

neooleg commented Mar 16, 2018

@kmossco could you pls update -- is there is any progress?

@kmossco
Copy link
Contributor Author

kmossco commented Mar 17, 2018

So sorry for the delay in getting this out of the door. We unfortunately hit a snag creating the Nuget package in a way that it doesn't break plenty of apps that don't want to upgrade the library, and we are working to create a new release. We should have an update very soon though!

@neooleg
Copy link

neooleg commented Mar 17, 2018 via email

@NPSF3000
Copy link

@kmossco thanks for the update 😊

@niemyjski
Copy link

+1, also can we get a fully async api :D

@kmossco
Copy link
Contributor Author

kmossco commented Mar 26, 2018

@niemyjski that's definitely in our plans too! 😄

@kmossco kmossco added the triaged label Apr 1, 2018
@kmossco
Copy link
Contributor Author

kmossco commented Apr 11, 2018

Closing this as we have now a new version out that supports DotNetStandard. Going through the issues already open and will work next on adding the missing features to the SDK. Please let us know if you spot any problems/errors. 🎉

@kmossco kmossco closed this as completed Apr 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants