Target .NET Standard #116
Merged
Target .NET Standard #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This isn't currently used by the core library (and probably shouldn't be anyway). Removing the reference ensures the tests SDK isn't enforced as a dependency by consumers of the NuGet package.
kmossco
approved these changes
Apr 26, 2018
There was a problem hiding this comment.
I think this slipped by because we had to change to netcore due to this issue with NUnit: https://github.com/nunit/docs/wiki/.NET-Core-and-.NET-Standard#why-cant-my-tests-target-net-standard
But I agree that we should not impose this dependency on the target application. Thank you for adding this!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the target from .NET Core App 2.0 to .NET Standard 2.0. This should correct #115. It also removes the dependency to the test SDK, which isn't required by the core library. With that dependency in place, NuGet forwards that dependency on to consumers of the package.