Include count on segment

[ThomasArdal]

No description provided.

[ThomasArdal]

Any ETA on getting this reviewed and merged?

[kmossco]

Hey @ThomasArdal! So sorry for the delay in getting back to you here, and thank you so much for taking the time to help us! Right now we are blocked in releasing a new version due to a problem with our MyGet releases: #115 (comment)

I am hoping to get this sorted asap so we can resume merging and as soon as we do that your PR will be reviewed and merged right away.

[kmossco]

Small change request and we will be good to go! 🚀

[kmossco]

I tested this locally and the problem with this approach is that we will always send the attribute even if it's false. So the params we get in the server when this is sent like this: Segment segments = segmentsClient.View("58c67482ac0f91a20446037e"); are:

"params":{"include_count":"False","id":"58c67482ac0f91a20446037e"}

So this will return the count anyway. Can we instead of defining it as false, actually define as null? Maybe something like this:

public Segment View(String id, bool? includeCount = null)
{
    if (String.IsNullOrEmpty(id))
    {
        throw new ArgumentNullException(nameof(id));
    }

    Dictionary<String, String> parameters = new Dictionary<String, String>();
    if (includeCount != null && includeCount.HasValue)
            {
                parameters.Add("include_count", includeCount.ToString());
            }

[ThomasArdal]

@kmossco Good point. Fixed.

[kmossco]

This closes #122

[kmossco]

Sorry for the delay, this looks good now. 🚢 Going to wrap it with #129, #130, #131 into version 2.1.0 of this library. So will merge it soon.