Remove cookie on signout by specifying domain #278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding the `domain` key to the cookie when it's either not present, or `localhost` results in the cookie not being deleted. The code already handled the nil case, but not the `localhost` case. This handles both.
|
So, who do I got to tickle @intercom to get this merged in? |
|
Looks great, thank you! |
danielhusar
approved these changes
May 22, 2018
|
This is now available in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds on #266, but also handles the case of
localhost.As mentioned in #266 and #194,
IntercomRails::ShutdownHelper.intercom_shutdowndoes not actually remove the cookie. Meaning folks aren't actually signed out! This happens because theintercom-session-INTERCOM_IDcookie is set with a domain value. Thus, we need to include the same value as the:domainkey when removing the cookie. The Rails docs say as muchThis PR builds atop @BastienL by also handling the case of
localhostcorrectly.This needs attention 🔜 as it's an open security and privacy issue for all users of
intercom-rails.