Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove parachain packages #500

Merged
merged 4 commits into from
Jul 28, 2023
Merged

fix: remove parachain packages #500

merged 4 commits into from
Jul 28, 2023

Conversation

nakul1010
Copy link
Member

@nakul1010 nakul1010 commented Jul 24, 2023 •
edited
Loading

Closes #498
The PR adds the following things

  • remove module_btc_relay
  • remove oracle-rpc-runtime-api
  • Fix warnings

@nakul1010 nakul1010 added the InProgress The PR is still in progress label Jul 24, 2023
@nakul1010 nakul1010 self-assigned this Jul 24, 2023
@nakul1010 nakul1010 marked this pull request as draft July 24, 2023 08:24
@nakul1010
Copy link
Member Author

nakul1010 commented Jul 24, 2023 •
edited
Loading

PR #496, #1137 and #1138 need to get merge first, before merging this PR.

@nakul1010 nakul1010 force-pushed the nakul/fix_remove_parachain_dependency branch from 4e283a3 to 525b74b Compare July 27, 2023 13:54
nakul1010 added 2 commits July 27, 2023 19:25
@nakul1010
Merge branch 'master' of https://github.com/interlay/interbtc-clients …
bb11da4 
…into nakul/fix_remove_parachain_dependency

# Conflicts:
#	Cargo.lock
#	runtime/Cargo.toml
#	runtime/src/utils/account_id.rs
@nakul1010
fix: remove unused imports
b1cdc57
@nakul1010 nakul1010 requested a review from sander2 July 27, 2023 13:58
@nakul1010 nakul1010 added ReviewNeeded The discussion can be reviewed by peers and removed InProgress The PR is still in progress labels Jul 27, 2023
@nakul1010 nakul1010 requested a review from gregdhill July 27, 2023 13:58
@nakul1010 nakul1010 marked this pull request as ready for review July 27, 2023 18:04
@gregdhill gregdhill merged commit fe03c49 into master Jul 28, 2023
@gregdhill gregdhill deleted the nakul/fix_remove_parachain_dependency branch July 28, 2023 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gregdhill gregdhill gregdhill approved these changes

@sander2 sander2 Awaiting requested review from sander2

Assignees

@nakul1010 nakul1010

Labels
ReviewNeeded The discussion can be reviewed by peers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove parachain packages dependency
2 participants
@nakul1010 @gregdhill