chore: refactor custom header implementation #2010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for brilliant-pasca-3e80ec canceled.
|
huijing
changed the title
github-actions
bot
added
the
pkg: documentation
huijing
force-pushed
the
chj/2007/refactor-custom-header
branch
from
4d16f68 to
6a458ed
Compare
huijing
commented
Oct 9, 2023
| @@ -188,12 +189,6 @@ export default defineConfig({ | |||
| linkPrefix: '/apis/auth/' | |||
| }) | |||
| ], | |||
| // Process images with sharp: https://docs.astro.build/en/guides/assets/#using-sharp | |||
There was a problem hiding this comment.
We are not running our images through the sharp pipeline
huijing
commented
Oct 9, 2023
| @@ -1,21 +1,18 @@ | |||
| --- | |||
| import type { Props } from '@astrojs/starlight/props'; | |||
There was a problem hiding this comment.
This is the official method of doing Starlight component override, see https://starlight.astro.build/guides/overriding-components/ for documentation.
huijing
force-pushed
the
chj/2007/refactor-custom-header
branch
from
6a458ed to
fa48938
Compare
huijing
force-pushed
the
chj/2007/refactor-custom-header
branch
from
fa48938 to
5d3bf8c
Compare
sabineschaller
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
Context
Closes #2007
Checklist
fixes #number