feat(auth): fix httpsig bypass env #735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
pkg: auth
wilsonianb
previously approved these changes
Nov 8, 2022
| @@ -195,7 +195,9 @@ export class App { | |||
| path: '/', | |||
| method: HttpMethod.POST | |||
| }), | |||
| grantInitiationHttpsigMiddleware, | |||
| this.config.bypassSignatureValidation | |||
There was a problem hiding this comment.
Should the existing bypass be removed?
rafiki/packages/auth/src/signature/middleware.ts
Lines 25 to 28 in d808c85
There was a problem hiding this comment.
it is pretty redundant now, yeah.
wilsonianb
previously approved these changes
Nov 8, 2022
| }) | ||
|
|
||
| const altContainer = await createTestApp(altDeps) | ||
| appContainers.push(altContainer) |
There was a problem hiding this comment.
You could also revert appContainers to appContainer
https://github.com/interledger/rafiki/pull/683/files#diff-9c6c5d794c9dfa6afb4129ccc2ffb701bcdecb70308c63c7e4d615e8d903859c
wilsonianb
approved these changes
Nov 9, 2022
This was referenced Nov 10, 2022
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
Conditionally adds httpsig middleware depending on the setting of the env variable for bypassing httpsig validation.
Context
This conditional used to be in the code but refactors of
app.tshave caused it to be removed.Checklist
fixes #number