Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update IL-RFC-30 discussion of timestamps and GeneralizedTime wrt ILP and BTP #480

Closed
sappenin opened this issue Sep 28, 2018 · 8 comments
Closed
Assignees
Labels

Comments

@sappenin
Copy link
Contributor

This ASN.1 definition for BTP specifies GeneralizedTime as the type for Error.triggeredAt and Prepare.expiresAt.

However, per this comment from @adrianhopebailie, no ASN.1 definitions should reference GeneralizedTime, but should instead use InterledgerTimestamps (see spec here).

@emschwartz
Copy link
Member

Actually BTP does use Generalized Time rather than Interledger timestamps: https://github.com/interledgerjs/btp-packet/blob/master/index.js#L26-L27

@sappenin
Copy link
Contributor Author

sappenin commented Sep 28, 2018

Ah, yes, you're right.

So, it seems like Interledger packets use Interledger timestamps but BTP is using the special variant of GeneralizedTime (per your link above).

So, I suppose IL-RFC-30 is incorrect, then? Those rules only apply to BTP, but not to ILP packets?

@adrianhopebailie
Copy link
Collaborator

So, I suppose IL-RFC-30 is incorrect, then?

Yes. It needs to be updated.

However, per this comment from @adrianhopebailie, no ASN.1 definitions should reference GeneralizedTime, but should instead use InterledgerTimestamps

Sorry, I meant for ILP. The rationale for the switch was fixed size which is probably less relevant for BTP

@sappenin
Copy link
Contributor Author

sappenin commented Oct 5, 2018

Makes sense - so I think the ASN definition is correct, but IL-RFC-30 needs to be cleaned up. Should I create a separate ticket and close this one?

@adrianhopebailie adrianhopebailie changed the title BTP's ASN definition specifies GeneralizedTime Update IL-RFC-30 discussion of timestamps and GeneralizedTime wrt ILP and BTP Oct 8, 2018
@adrianhopebailie
Copy link
Collaborator

Let's just track it here for context.

@stale
Copy link

stale bot commented Nov 7, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

If this issue is important, please feel free to bring it up on the next Interledger Community Group Call or in the Gitter chat.

@stale stale bot added the wontfix label Nov 7, 2018
@sappenin
Copy link
Contributor Author

sappenin commented Nov 9, 2018

Bumping to keep this open a bit longer...

@stale stale bot removed the wontfix label Nov 9, 2018
@stale
Copy link

stale bot commented Dec 9, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

If this issue is important, please feel free to bring it up on the next Interledger Community Group Call or in the Gitter chat.

@stale stale bot added the wontfix label Dec 9, 2018
@stale stale bot closed this as completed Dec 16, 2018
@sappenin sappenin reopened this Jan 26, 2019
@stale stale bot removed the wontfix label Jan 26, 2019
sappenin added a commit that referenced this issue Jan 26, 2019
* Fixes #480
* Fixes #481

Signed-off-by: sappenin <[email protected]>
adrianhopebailie pushed a commit that referenced this issue Feb 11, 2019
* Update OER Encoding of Dates

* Fixes #480
* Fixes #481

Signed-off-by: sappenin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants